[WIP] fix(core): expose unstable_resolve instead of unstable_is #2609

dmaskasky · 2024-06-07T02:02:51Z

Related Issues or Discussions

Replaces PR: #2569

Context

jotai-scope implementation can be made simpler if the store exposed the ability to customize which atom config to reference based on another atom config.

Summary

unstable_resolve is a new store method. This method customizes how atoms are resolved by their atom config (e.g. using an atom as a key to look up another atom). By default the resolve behavior is atom => atom.

ResolveAtom Invocation Sites

The following functions convert their atom arg to a resolved atom. Since these six functions cover the store interface, it is not necessary to call resolveAtom elsewhere.

readAtom
writeAtom
subscribeAtom
readAtomState -> getter
writeAtomState -> getter
writeAtomState -> setter

Note: store dev methods do not call resolveAtom. The caller of these dev methods is expected to handle atom resolution.

Example

const pseudo = atom('pseudo')
const a = atom('a')
const store = createStore()
store.unstable_resolve = (atom) => atom === pseudo ? a : atom
expect(store.get(pseudo)).toBe('a')

TODO

Determine if this change is sufficient for jotai-scope

Check List

pnpm run prettier for formatting code and docs

vercel · 2024-06-07T02:02:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2024 5:59pm

codesandbox-ci · 2024-06-07T02:03:25Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions · 2024-06-07T02:04:15Z

Preview in LiveCodes

Latest commit: 9ec28ce
Last updated: Jun 24, 2024 5:58pm (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/CNM5S8ZNH

See documentations for usage instructions.

codesandbox-ci · 2024-06-07T02:15:36Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T02:24:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T21:38:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T21:46:51Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T21:48:17Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T21:53:16Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T21:56:13Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci · 2024-06-07T23:25:42Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi

This looks super cool! Thanks for your contribution.
Now, this PR fixes both store and store2, I think it can be released as a patch.

codesandbox-ci · 2024-06-19T00:58:55Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dmaskasky · 2024-06-24T17:30:41Z

[DO_NOT_MERGE] I am still trying to understand whether this change will satisfy the needs of jotai-scope. I might go in a slightly different direction.

Co-authored-by: David Maskasky <dmaskasky@otter.ai>

* add failing tests for unstable_resolve * Apply suggestions from code review * Apply suggestions from code review * Update tests/vanilla/store.test.tsx * hack types --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com> Co-authored-by: daishi <daishi@axlight.com>

* experimental(core): expose unstable_derive instead of unstable_is * chore: remove empty line * chore types * follow resolveAtom in #2609 * store test from #2609 * adjust store.test.tsx for unstable_derive * limit atom state map type * add test with atom state map * update test using unstable_derive * drop resolveAtom, add derive atom test * simplify unstable_derive * wip: this works but i do not like it * separate atomstate and atomcontext * for old ts * fix * fix 2 * simplify a bit with dev breaking changes * revert to bd9c6c0, except for new test * refactor (skipping the new test for now) * refactor 2 * revert those refactors :-p * wip: hm, how is bundle size? * fix tests * add test for unstable_derive (#2665) * add a failing test * wip: failed attempt * split unstable_derive test * wip: failed attempt 2 * revert failing tests * empty commit * restore unstable_is of now (we will remove it in the later version.) --------- Co-authored-by: David Maskasky <dmaskasky@gmail.com> Co-authored-by: David Maskasky <dmaskasky@otter.ai>

vercel bot deployed to Preview June 7, 2024 02:03 View deployment

dmaskasky changed the base branch from expose-store-get-atom to main June 7, 2024 02:03

dmaskasky force-pushed the expose-store-get-atom-2 branch from 6102035 to 896bc81 Compare June 7, 2024 02:15

dmaskasky changed the base branch from main to expose-store-get-atom June 7, 2024 02:15

dmaskasky changed the base branch from expose-store-get-atom to main June 7, 2024 02:15

vercel bot deployed to Preview June 7, 2024 02:15 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from 896bc81 to 2480e0b Compare June 7, 2024 02:23

vercel bot deployed to Preview June 7, 2024 02:24 View deployment

dmaskasky changed the title ~~Expose store get atom 2~~ [WIP] Expose store get atom 2 Jun 7, 2024

dmaskasky force-pushed the expose-store-get-atom-2 branch from 2480e0b to 18e83e7 Compare June 7, 2024 21:38

vercel bot deployed to Preview June 7, 2024 21:39 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from 18e83e7 to ade00a6 Compare June 7, 2024 21:46

vercel bot deployed to Preview June 7, 2024 21:46 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from ade00a6 to 42244ac Compare June 7, 2024 21:47

vercel bot deployed to Preview June 7, 2024 21:48 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from 42244ac to a6b9322 Compare June 7, 2024 21:52

vercel bot deployed to Preview June 7, 2024 21:53 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from a6b9322 to b8b1b23 Compare June 7, 2024 21:55

vercel bot deployed to Preview June 7, 2024 21:56 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from b8b1b23 to 2de29ae Compare June 7, 2024 23:10

dmaskasky changed the title ~~[WIP] Expose store get atom 2~~ Expose store get atom 2 Jun 7, 2024

dmaskasky force-pushed the expose-store-get-atom-2 branch 2 times, most recently from 008323a to 3acc1b9 Compare June 7, 2024 23:25

vercel bot deployed to Preview June 7, 2024 23:26 View deployment

dmaskasky mentioned this pull request Jun 11, 2024

Scope caused atomWithObservable to be out of sync jotaijs/jotai-scope#36

Open

dai-shi approved these changes Jun 19, 2024

View reviewed changes

dai-shi mentioned this pull request Jun 19, 2024

fix(core): expose unstable_resolve instead of unstable_is #2569

Closed

dai-shi changed the title ~~Expose store get atom 2~~ fix(core): expose unstable_resolve instead of unstable_is Jun 19, 2024

vercel bot deployed to Preview June 19, 2024 01:00 View deployment

dmaskasky force-pushed the expose-store-get-atom-2 branch from 89fe100 to 7e259b9 Compare June 24, 2024 02:06

vercel bot deployed to Preview June 24, 2024 02:06 View deployment

dmaskasky changed the title ~~fix(core): expose unstable_resolve instead of unstable_is~~ [WIP] fix(core): expose unstable_resolve instead of unstable_is Jun 24, 2024

dai-shi and others added 6 commits June 24, 2024 10:58

fix(core): expose unstable_resolve instead of unstable_is

5df50a4

just an idea

f067b95

another idea

9db40a2

Co-authored-by: David Maskasky <dmaskasky@otter.ai>

fix: failing unstable_resolve tests

9af3efa

feat: add store.unstable_derive api

9ec28ce

dmaskasky force-pushed the expose-store-get-atom-2 branch from 7e259b9 to 9ec28ce Compare June 24, 2024 17:58

vercel bot deployed to Preview June 24, 2024 17:59 View deployment

dai-shi marked this pull request as draft June 24, 2024 22:51

dai-shi mentioned this pull request Jul 9, 2024

experimental(core): expose unstable_derive #2652

Merged

dai-shi added a commit that referenced this pull request Jul 10, 2024

follow resolveAtom in #2609

1c35229

dai-shi pushed a commit that referenced this pull request Jul 10, 2024

store test from #2609

e92f1c1

dmaskasky closed this Jul 16, 2024

dmaskasky deleted the expose-store-get-atom-2 branch July 16, 2024 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] fix(core): expose unstable_resolve instead of unstable_is #2609

[WIP] fix(core): expose unstable_resolve instead of unstable_is #2609

dmaskasky commented Jun 7, 2024 •

edited

Loading

vercel bot commented Jun 7, 2024 •

edited

Loading

codesandbox-ci bot commented Jun 7, 2024

github-actions bot commented Jun 7, 2024 •

edited

Loading

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

dai-shi left a comment

codesandbox-ci bot commented Jun 19, 2024 •

edited

Loading

dmaskasky commented Jun 24, 2024

[WIP] fix(core): expose unstable_resolve instead of unstable_is #2609

[WIP] fix(core): expose unstable_resolve instead of unstable_is #2609

Conversation

dmaskasky commented Jun 7, 2024 • edited Loading

Related Issues or Discussions

Context

Summary

ResolveAtom Invocation Sites

Example

TODO

Check List

vercel bot commented Jun 7, 2024 • edited Loading

codesandbox-ci bot commented Jun 7, 2024

github-actions bot commented Jun 7, 2024 • edited Loading

Preview in LiveCodes

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

codesandbox-ci bot commented Jun 7, 2024

dai-shi left a comment

Choose a reason for hiding this comment

codesandbox-ci bot commented Jun 19, 2024 • edited Loading

dmaskasky commented Jun 24, 2024

dmaskasky commented Jun 7, 2024 •

edited

Loading

vercel bot commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading

codesandbox-ci bot commented Jun 19, 2024 •

edited

Loading