idea1: add originator prop to atomFamily atoms #2678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/DK7S5BLGC |
See documentations for usage instructions.
1 task
dmaskasky
changed the title
dmaskasky
changed the title
dai-shi
reviewed
Jul 29, 2024
| @@ -43,6 +45,7 @@ export function atomFamily<Param, AtomType extends Atom<unknown>>( | |||
| } | |||
|
|
|||
| const newAtom = initializeAtom(param) | |||
| ;(newAtom as any)[SymbolOriginator] = createAtom | |||
There was a problem hiding this comment.
Is createAtom just used as a reference key?
It doesn't seem very straightforward and useful.
1 task
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
idea2: #2679
Fixes #
jotaijs/jotai-scope#50
Summary
jotai-scope is trying to support scoping atomFamily.
This PR demonstrates one approach in which the atomFamily annotates atoms created by this approach with an originator symbol set to the createAtom function.
The following pseudo code represents logic that would live in jotai-scope
Check List
pnpm run prettierfor formatting code and docs