refactor(store): prefer epoch number comparisons to indicate value change #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/24HTLQVM5 |
See documentations for usage instructions.
dai-shi
approved these changes
Nov 18, 2024
| const v = args[0] as V | ||
| setAtomStateValueOrPromise(a, aState, v) | ||
| mountDependencies(pending, a, aState) | ||
| if (!hasPrevValue || !Object.is(prevValue, aState.v)) { | ||
| if (prevEpochNumber !== aState.n) { |
There was a problem hiding this comment.
This looks really good and I probably missed it when introducing the epoch number.
My concern was for the error case, but the epoch number is incremented with delete atomState.v, so it should be fine.
dai-shi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces value comparisons with epoch number changes. This may help prevent memory leaks.
Check List
pnpm run prettierfor formatting code and docs