feat(core): introduce atom.unstable_onInit hook #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: +204 B (+0.22%) Total Size: 92.5 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/A2K8RKVLB |
See documentations for usage instructions.
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dmaskasky
commented
Jan 4, 2025
dai-shi
reviewed
Jan 4, 2025
- move atomSyncEffect to effect.test.ts - rename to syncEffect - remove debug statements - syncEffect mutates batch iterator to insert syncEffect channel
dai-shi
reviewed
Jan 5, 2025
dai-shi
reviewed
Jan 5, 2025
…e need tests for them to dig further.
dai-shi
approved these changes
Jan 5, 2025
dai-shi
changed the title
…partial-sync-effect-6
dai-shi
approved these changes
Jan 6, 2025
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
#2888
#2801
#2901
Summary
Uses atomState change and mount hooks to schedule effect and cleanup.
Key Points
atom.unstable_onInit(atom.unstable_onInit = (store: Store) => void) that fires in place when an atomState is first created in the store for that atom.storeis passed as params toatom.unstable_onInit.store.unstable_deriveapi to add a new callback param,atomOnInit. This is the interceptor for theatom.unstable_onInitapi. Since getAtomState is whereatom.unstable_onInitis called, we must addatomOnInitto the getAtomState params.atomOnInitaccepts a store arg so that the current store is always passed.atomState.hthat fires in-place when an atom has mounted or unmounted, and if an atom has unmounted it schedules a cleanup to run with batch priority 0.5. Batch is a param passed toatomState.hfunction.atomState.uthat fires in-place when an atom has updated, and if an atom has updated it schedules an effect to run with batch priority 0.5. Batch is a param passed toatomState.ufunction.Check List
pnpm run prettierfor formatting code and docs