Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): Add initialValues to debugstore init #566

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

Thisen
Copy link
Collaborator

@Thisen Thisen commented Jun 27, 2021

Fixes #565

@vercel
Copy link

vercel bot commented Jun 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/DGDehUMubgGy63rcRseDwgbNisLi
✅ Preview: https://jotai-git-fix-respect-initial-values-for-snapshots-pmndrs.vercel.app

@Thisen Thisen requested a review from dai-shi June 27, 2021 10:13
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1931dbc:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Member

dai-shi commented Jun 27, 2021

@xbaun Would you try this fix?
See https://ci.codesandbox.io/status/pmndrs/jotai/pr/566 "Local install instructions"

@xbaun
Copy link
Contributor

xbaun commented Jun 27, 2021

It's working 👍

@dai-shi dai-shi merged commit 6d767a7 into master Jun 27, 2021
@dai-shi dai-shi deleted the fix/respect-initial-values-for-snapshots branch June 27, 2021 12:39
@dai-shi
Copy link
Member

dai-shi commented Jun 27, 2021

We will release this with other changes.
In the mean time, feel free to keep using the csb build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useAtomsSnapshot ignores initialValues atoms
3 participants