fix(weakCache): Replace recursion with while loop to avoid too much recursion

[Thisen]

Fixes #630

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/FR2N4jSDXSLGQHL4b3yZ1c5EBHXs
✅ Preview: https://jotai-git-fix-waitforall-too-much-recursion-pmndrs.vercel.app

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 073b470:

Sandbox	Source
React	Configuration
React Typescript	Configuration
jolly-turing-g3h5f	Issue #630

[dai-shi]

Great you found a solution!
I'd like to understand the issue and possibly come up with alternative solution.

So, is this only the issue with the weakCache? If we didn't use getWeakCacheItem by commenting out, would the test pass? (well, I can try...)

[Thisen]

The issue seems to be too much recursion, JS doesn't handle that very well. Another solution would be a for loop, but I'm not sure how you would do that, given the current algorithm, where you push the item into the entry in setWeakCacheItem>

[dai-shi]

Oh, I see. It's recursion. Yeah, I kind of knew this would happen.
I think we can implement with for-loop. Would you like to try or want me to try?

[dai-shi]

Yay! Thanks for finding the solution and fixing it!