refactor(core): useMutableSource emulation without symbol and any #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/4CTYPzS41DSpHonWjmNezSKWkWAv |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 327c1c5:
|
Thisen
approved these changes
Aug 9, 2021
| @@ -9,20 +9,28 @@ export { | |||
|
|
|||
| import { useEffect, useRef, useState } from 'react' | |||
|
|
|||
| const TARGET = Symbol() | |||
| const GET_VERSION = Symbol() | |||
| const TARGET = '_uMS_T' | |||
There was a problem hiding this comment.
Why remove the use of Symbol?
There was a problem hiding this comment.
Because, with internal symbols, TS can't emit types properly. That's why any was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to follow pmndrs/valtio#208 (we use the same code.)
@Thisen once suggested to have precise typing in useMutableSource.ts. This covers it.