Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(useAtomsSnapshot): Only use values in snapshots #652

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

Thisen
Copy link
Collaborator

@Thisen Thisen commented Aug 12, 2021

Related to #650

@vercel
Copy link

vercel bot commented Aug 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/2CrDRP7KRmaTrHNhas9dyUnH1nbX
✅ Preview: https://jotai-git-fix-only-use-values-in-snapshots-pmndrs.vercel.app

@Thisen Thisen requested a review from dai-shi August 12, 2021 12:29
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a661d6:

Sandbox Source
React Configuration
React Typescript Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I think it's pretty safe to merge this only with the code review.

@dai-shi dai-shi merged commit cc760f3 into main Aug 12, 2021
@dai-shi dai-shi deleted the fix/only-use-values-in-snapshots branch August 12, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants