fix(core,query): handle edge cases with writeAtom returning a promise #701
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/C62GeUBwB1xsEKy4xGPAd5DhAHF4 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7036fae:
|
src/core/store.ts
Outdated
| flushPending() | ||
| }) | ||
| return | ||
| return writePromise.then(() => writeAtomState(atom, update)) |
There was a problem hiding this comment.
Is it possible to write a test for this inside core?
There was a problem hiding this comment.
I don't know. I can try. Do you know what this does?
There was a problem hiding this comment.
Actually, I'm not sure if we need this, as now writeAtom returns a promise.
There was a problem hiding this comment.
What I meant, is if you can write a test inside core, for the edge cases - Not the particular line. I'm sorry for not being clear.
There was a problem hiding this comment.
Sorry, I wasn't clear. You made a good point, we don't have a test for this, even if you don't know what it does.
The reason we didn't have a test is because we didn't know the actual use case.
Now, I feel like this isn't necessary at all. I will remove it completely.
| ): void => { | ||
| const [atomState] = wipAtomState(atom) | ||
| if (promise) { | ||
| atomState.w = promise | ||
| } else { | ||
| } else if (atomState.w === prevPromise) { |
There was a problem hiding this comment.
Could you explain this with a comment?
#689 changed
writeAtomto return a promise. This is a follow-up PR to cover some edge cases.