-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): simplify exports and support nested subpath #704
Conversation
dai-shi
commented
Sep 12, 2021
•
edited
Loading
edited
- simplifies exports in package.json
- supports nested subpath in rollup.config.js
- update node version from 12 to 14
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/HZ9cZCEbRMRu8TDQsZ8LsWFwDCrP |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a134985:
|
#697 (comment) |
@barelyhuman Does this "exports" look good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Thisen test failed. 😱 |
@dai-shi Seems to be working with the TS Exports, which I guess was my only concern here so yeah it works! 👍🏼 |
Great to hear that. I will create the same PRs in zustand and valtio. |