Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): simplify exports and support nested subpath #704

Merged
merged 4 commits into from
Sep 12, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Sep 12, 2021

  • simplifies exports in package.json
  • supports nested subpath in rollup.config.js
  • update node version from 12 to 14

@vercel
Copy link

vercel bot commented Sep 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/HZ9cZCEbRMRu8TDQsZ8LsWFwDCrP
✅ Preview: https://jotai-git-chore-exports-patten-and-subpath-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a134985:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration

@dai-shi
Copy link
Member Author

dai-shi commented Sep 12, 2021

#697 (comment)
@Thisen Sorry, replaceAll doesn't work, using replace instead.

@dai-shi
Copy link
Member Author

dai-shi commented Sep 12, 2021

@barelyhuman Does this "exports" look good?

Copy link
Collaborator

@Thisen Thisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi
Copy link
Member Author

dai-shi commented Sep 12, 2021

@Thisen test failed. 😱

@Thisen
Copy link
Collaborator

Thisen commented Sep 12, 2021

@Thisen test failed. 😱

@dai-shi, It's fixed now

@barelyhuman
Copy link
Collaborator

@dai-shi Seems to be working with the TS Exports, which I guess was my only concern here so yeah it works! 👍🏼

@dai-shi
Copy link
Member Author

dai-shi commented Sep 12, 2021

Great to hear that. I will create the same PRs in zustand and valtio.

@dai-shi dai-shi changed the title chore: simplify exports and supports nested subpath for the future chore(build): simplify exports and support nested subpath Sep 12, 2021
@dai-shi dai-shi merged commit 7d23e1c into main Sep 12, 2021
@dai-shi dai-shi deleted the chore/exports-patten-and-subpath branch September 12, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants