Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for #728 #729

Closed
wants to merge 2 commits into from
Closed

add test for #728 #729

wants to merge 2 commits into from

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Sep 23, 2021

for #728

@vercel
Copy link

vercel bot commented Sep 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/XehGj2t2wBXX8UPWieVTALrDa8YK
✅ Preview: https://jotai-git-fix-issue-728-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20a67c0:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: 0 B

Total Size: 37.4 kB

ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/preset.js 819 B
dist/devtools.js 1.56 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/preset.js 648 B
dist/esm/devtools.js 1.4 kB
dist/esm/immer.js 591 B
dist/esm/index.js 4.28 kB
dist/esm/optics.js 639 B
dist/esm/query.js 1.28 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.43 kB
dist/esm/utils.js 4.24 kB
dist/esm/valtio.js 487 B
dist/esm/xstate.js 947 B
dist/esm/zustand.js 284 B
dist/immer.js 729 B
dist/index.js 5.19 kB
dist/optics.js 934 B
dist/query.js 1.38 kB
dist/redux.js 314 B
dist/urql.js 1.48 kB
dist/utils.js 5.13 kB
dist/valtio.js 552 B
dist/xstate.js 1.04 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented Sep 27, 2021

It turns out this is not what is reported in #728.

@dai-shi dai-shi closed this Sep 27, 2021
@dai-shi dai-shi deleted the fix/issue-728 branch September 27, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant