Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(website): add atomWithObservable to utils section #774

Merged
merged 1 commit into from
Oct 13, 2021
Merged

docs(website): add atomWithObservable to utils section #774

merged 1 commit into from
Oct 13, 2021

Conversation

ricmello
Copy link
Contributor

Continuation of #341, adding the atomWithObservable usage to the utils section.

But the CodeSandbox is failing due to #760.

@vercel
Copy link

vercel bot commented Oct 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/DXarTmVazmv6KwLyddKDqcETrYaa
✅ Preview: https://jotai-git-fork-ricmello-docs-atom-with-observable-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e452b6:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

dai-shi
dai-shi reviewed Oct 13, 2021
View reviewed changes
docs/api/utils.mdx Outdated
@@ -220,6 +247,7 @@ const countReducer = (prev, action) => {
const countReducerAtom = atomWithReducer(0, countReducer)
```

<CodeSandbox id="g3tsx" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😳. removed

@dai-shi
Copy link
Member

dai-shi commented Oct 13, 2021

https://codesandbox.io/s/88pnt Hmm, this doesn't work even without redux devtools ext.

dai-shi
dai-shi approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we comment out the codesandbox, or just merge this as is?

@ricmello
Copy link
Contributor Author

https://codesandbox.io/s/88pnt Hmm, this doesn't work even without redux devtools ext.

Yeah, it's failing at the exact same point. Looks that they also have the Observable symbol set. I think that's better to comment the CodeSandbox and wait for the fix.

I also added a link to the async page when asking for the Suspense usage.

@dai-shi
Copy link
Member

dai-shi commented Oct 13, 2021

Looks good. Let's merge this and prioritize #760.
Thanks for your contribution!

@dai-shi dai-shi merged commit 2e415de into pmndrs:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricmello @dai-shi