Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(valtio): length of array didn't update (#785) #786

Merged
merged 2 commits into from
Oct 23, 2021
Merged

fix(valtio): length of array didn't update (#785) #786

merged 2 commits into from
Oct 23, 2021

Conversation

Mingx94
Copy link
Contributor

@Mingx94 Mingx94 commented Oct 18, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/Ey966wAVrseHKWQivN7LR7Ld2mny
✅ Preview: https://jotai-git-fork-mingx94-main-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 18, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b3b247e:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@dai-shi dai-shi linked an issue Oct 18, 2021 that may be closed by this pull request
atomWithProxy with array did not work as my expect #785
Closed
@dai-shi
Copy link
Member

dai-shi commented Oct 18, 2021

https://codesandbox.io/s/lingering-silence-smswt?file=/src/App.js
it's working.

dai-shi
dai-shi approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix and test look good. Thanks for your contribution!

@dai-shi dai-shi added this to the v1.4.1 milestone Oct 18, 2021
@dai-shi dai-shi merged commit 6802164 into pmndrs:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

atomWithProxy with array did not work as my expect
2 participants
@Mingx94 @dai-shi