Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): improve invalidated revision #821

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 7, 2021

we should clear obsoleted invalidated revision, so that we can skip checking.
there would be room for improvement in AtomState types. will revisit it in the future.

@vercel
Copy link

vercel bot commented Nov 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/2aSpkASDEFnNLABtseKyCQKVKwGX
✅ Preview: https://jotai-git-refactor-coreclear-invalidated-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6df008b:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

Size Change: +2 B (0%)

Total Size: 39.7 kB

Filename Size Change
dist/esm/index.js 4.2 kB +1 B (0%)
dist/index.js 5.04 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/devtools.js 1.56 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/devtools.js 1.4 kB
dist/esm/immer.js 592 B
dist/esm/optics.js 640 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.43 kB
dist/esm/utils.js 4.26 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 947 B
dist/esm/zustand.js 284 B
dist/immer.js 729 B
dist/optics.js 935 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.48 kB
dist/utils.js 5.21 kB
dist/valtio.js 586 B
dist/xstate.js 1.04 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi added this to the v1.4.3 milestone Nov 7, 2021
@dai-shi dai-shi merged commit 39b05f2 into main Nov 7, 2021
@dai-shi dai-shi deleted the refactor/core/clear-invalidated branch November 7, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant