Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve infinite loop with derived atoms with onMount #900

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 20, 2021

close #897

@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/7azj4vKcpkNwk9tMDEM3sctC67oS
✅ Preview: https://jotai-git-fix-issue-897-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3570389:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

Size Change: -9 B (0%)

Total Size: 41.8 kB

Filename Size Change
dist/esm/index.js 4.45 kB -5 B (0%)
dist/index.js 5.21 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/devtools.js 1.74 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/devtools.js 1.59 kB
dist/esm/immer.js 616 B
dist/esm/optics.js 661 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.49 kB
dist/esm/utils.js 4.49 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 732 B
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.54 kB
dist/utils.js 5.72 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi changed the title add failing test for #897 fix(core): resolve infinite loop with derived atoms with onMount Dec 20, 2021
@dai-shi dai-shi marked this pull request as ready for review December 20, 2021 10:28
@dai-shi
Copy link
Member Author

dai-shi commented Dec 20, 2021

@dai-shi dai-shi added this to the v1.4.9 milestone Dec 20, 2021
Copy link
Collaborator

@Thisen Thisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dai-shi dai-shi merged commit d07bece into main Dec 20, 2021
@dai-shi dai-shi deleted the fix/issue-897 branch December 20, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useAtom has something wrong when dynamic return an atom
2 participants