Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAO is not working with three 0.153.0 on Android:Chrome #506

Closed
marwie opened this issue Jun 23, 2023 · 7 comments
Closed

SSAO is not working with three 0.153.0 on Android:Chrome #506

marwie opened this issue Jun 23, 2023 · 7 comments
Labels
device issue Caused by a specific device or device family

Comments

@marwie
Copy link

marwie commented Jun 23, 2023

Description of the bug

Running the SSAO sample on android chrome doesnt have any SSAO

To Reproduce

  1. Pull postprocessing package. I tested with c3ce388

  2. Modify hugo startup parameters to start on host ip address (so it can be opened via a phone in the same local network)
    "start": "hugo server -s manual -e development --bind=<your_ipv4> --baseURL=http://<your_ipv4>:1313",

Expected behavior

SSAO being rendered on android

Screenshots

image

Set intensity to maximum:

image

Library versions used

  • Three: 153
  • Post Processing: c3ce388

Mobile

  • Device: Pixel 6a
  • OS: Android 13
  • Browser Chrome 114.0.5735.131
@vanruesc
Copy link
Member

The error implies that the DepthDownsamplingMaterial doesn't explicitly define a precision for float arrays. That's strange though, because default precision declarations are usually injected automatically by three. Maybe this has to do with how the arrays are initialized. Does your device support WebGL 2 or does it fall back to WebGL 1?

@marwie
Copy link
Author

marwie commented Jun 26, 2023

Yes the Pixel 6a supports webgl 2 (double checked on https://get.webgl.org/webgl2/)

vanruesc added a commit that referenced this issue Jul 1, 2023
@vanruesc
Copy link
Member

vanruesc commented Jul 1, 2023

This is likely a driver/browser/angle bug because the precision declarations are definitely at the top of the shader.

I've added explicit precision qualifiers to float array declarations in postprocessing@6.32.2. Could you please check if this fixes the issue?

@marwie
Copy link
Author

marwie commented Jul 3, 2023

Hi, I just rebased on 6.32.2 and ran npm start but the issue still persists on my phone: no ssao visible

@vanruesc vanruesc added the device issue Caused by a specific device or device family label Oct 2, 2023
vanruesc added a commit that referenced this issue Oct 30, 2023
@vanruesc
Copy link
Member

I've changed the array initializations in postprocessing@6.33.3. It would be great if you could test again with this update.

@marwie
Copy link
Author

marwie commented Nov 10, 2023

Hi @vanruesc I just updated to 6.33.3 and it works there - thank you for the fix

@marwie marwie closed this as completed Nov 10, 2023
@vanruesc
Copy link
Member

Nice, thanks for checking 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device issue Caused by a specific device or device family
Projects
None yet
Development

No branches or pull requests

2 participants