Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 2 instances of SelectiveBloomEffect: second instance ignored, but its selection merges with the first #653

Closed
thibka opened this issue Aug 30, 2024 · 2 comments
Labels
support User support and general help

Comments

@thibka
Copy link

thibka commented Aug 30, 2024

Hi,

Description of the bug

When using two instances of SelectiveBloomEffect, only the first instance is effectively applied on screen. The second one seems ignored. However, the selection from the second instance ends up being added to the first bloom effect.

To reproduce

Here's a minimal demo.
https://codesandbox.io/p/sandbox/95hcm5

The first SelectiveBloomEffect targets the left cube, while the second targets the right cube.
The second bloom is not even used in the EffectPass, so it shouldn't have any effect. But its selection seems to be added to the first.

Expected behavior

The 2 SelectiveBloomEffect should independently affect their own selection.

Library versions used

  • Three: 0.167.0
  • Post Processing: 6.36.0
@vanruesc
Copy link
Member

Selective bloom uses Selection which means #464 (comment) applies here as well.

This is fixed in v7, but it probably won't hurt to backport that to v6...

@vanruesc vanruesc added the support User support and general help label Aug 31, 2024
@thibka thibka changed the title Using 2 Instances of SelectiveBloomEffect: Second Instance Ignored, but Its Selection Merges with the First Using 2 instances of SelectiveBloomEffect: second instance ignored, but its selection merges with the first Sep 1, 2024
@thibka
Copy link
Author

thibka commented Sep 1, 2024

Oh that makes sense, thanks!
However, the default selection.layer is actually 11.

@thibka thibka closed this as completed Sep 1, 2024
vanruesc added a commit that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support User support and general help
Projects
None yet
Development

No branches or pull requests

2 participants