Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible event handler / cpu leak in react-spring #222

Closed
mreishus opened this issue Sep 5, 2018 · 4 comments
Closed

Possible event handler / cpu leak in react-spring #222

mreishus opened this issue Sep 5, 2018 · 4 comments
Labels
kind: bug Something isn't working

Comments

@mreishus
Copy link

mreishus commented Sep 5, 2018

I've recreated it in this sandbox. https://codesandbox.io/s/ojj7l84q5y

It has instructions for testing in the HTML View. Maybe I'm using the Transition incorrectly, but I think there might be a CPU leak.
@mreishus
Copy link
Author

mreishus commented Sep 6, 2018

In my testing, it does not happen in 5.6.11 but happens in 5.6.12 and later.

@drcmda
Copy link
Member

drcmda commented Sep 6, 2018

@mreishus thanks for reporting, looks evil in there, it appends "NaN" over and over ... i'll look into it.

@drcmda drcmda added the kind: bug Something isn't working label Sep 6, 2018
@drcmda drcmda closed this as completed in 6029a16 Sep 6, 2018
@drcmda
Copy link
Member

drcmda commented Sep 6, 2018

Should be fine now!

@mreishus
Copy link
Author

mreishus commented Sep 7, 2018

Looks to work great, thanks

szjemljanoj pushed a commit to szjemljanoj/react-spring that referenced this issue Mar 29, 2019
@drcmda
fix pmndrs#222
49d72d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreishus @drcmda