react-spring causes tsserver / typescript to lag multiple seconds

[natew]

If you can hear my keystrokes you can see a huge delay suddenly happens when I import react-spring. I believe the types must be causing some trouble somewhere for typescript. I'm using typescript 3.4.1 and react-spring 8.0.18.

https://v.usetapes.com/hNl9HhHlSE

[natew]

This combined with #571 lost me quite a bit of debugging time tonight. Don't take this wrong, if the speed issue replicates it may be worth removing the types altogether until they are fixed, wrong types being worse than none.

[mrGibi]

I can confirm that using react-spring with typescript makes VsCode noticably slower and less responsive.

[drcmda]

I ... wouldn't know how to fix this tbh. I trust that contributors will figure that out on their own, all PR's are welcome of course. But i think we're making good progress with native TS types. @jacobrask has already transformed large parts of the code and perhaps at some point we can dump the definition files. But generally - if you need more TS support for this lib, please reach out - i will gladly deal out maintenance rights, i think it makes sense that a group of people watches over it.

[natew]

Yea I just wanted to note. It’s something weird happening as we use a ton of TS and this is the first time I’ve seen it. It’s also a 3-4 second delay, which is intense (accompanied with 100% cpu on both vscode and the compiler). So wanted to note for anyone else pulling hair. I got it fixed by just adding an override `declare module “react-spring”` for now.

[aleclarson]

@natew What are the callsites (if any) for animated or useSpring in your example?

[vadistic]

It's the first time I've ever seen <<unresolved>> as typescript value and I've tried many weird typings :) I'm thinking it's worth investigating as some TS edge-case/regression^^

Ok, now more seriously - I will not propose to make PR (since I'm quite new to this project), but here's patch-package patch.

It's really quick work but seems fine to me. I've dumbed down those problematic inferences and added few missing props and overloads to useTransition.

https://gist.github.com/vadistic/4878ac666a7bebde743eccd5ae01fad6

[bhollis]

I think the typings may just be a bit too clever - they're trying to use types to validate corresponding properties between different arguments, and it's just doing too much at once.

[aleclarson]

I'm in the process of improving the types. I'll have a PR up soon.

[charrondev]

@aleclarson Sweet. It might be good idea to try and write the various examples from the react spring site in typescript and make sure they pass tsc, similar to the *test.ts files in definitely typed definitions

[jgoz]

The react-spring typings were the reason I logged microsoft/TypeScript#29949. Glad to see them getting addressed in this repo too! The old typings weren’t wrong — they just made it easy to hit this Typescript bug ;)

[aleclarson]

The new types are available in the v9 branch. I hope to get v9.0.0-beta released soon.

[aleclarson]

You can use v9 like this now: yarn add react-spring@next

Let us know how it goes: #642