fix: update all values of animated array (#1430) #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ca5cc2:
|
joshuaellis
approved these changes
Jun 7, 2021
joshuaellis
added a commit
that referenced
this pull request
Jun 7, 2021
…1551) * chore: depreciate three-v5 * chore: add three-demo * feat: move rafz to part of monorepo * fix: use new rafz property to let r3f drive animation frames resolves #1518 * chore: delete travis * test: import from @react-spring/rafz * fix: update all values of animated array (#1430) (#1550) Co-authored-by: Michael Hutchings <michael.hutchings@cambridgeconsultants.com> * chore: update lock * fix: typescript errors * fix: allow declare Co-authored-by: Michael Hutchings <33626784+midanosi@users.noreply.github.com> Co-authored-by: Michael Hutchings <michael.hutchings@cambridgeconsultants.com>
cameron-martin
pushed a commit
to cameron-martin/react-spring
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixing bug #1430
What
Implemented suggested fix by a user in that thread, and wrote a unit test too.
I confirmed that the unit test failed in the expected way when the fix was not applied - i.e. spring of [10,20] is then updated to [11,21], but the resulting prop on animated div is still [11,20], because only the first animated value in the array was being updated.
Checklist