Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link color #1849

Merged
merged 2 commits into from
Feb 27, 2022
Merged

fix: link color #1849

merged 2 commits into from
Feb 27, 2022

Conversation

Fasani
Copy link
Member

@Fasani Fasani commented Feb 25, 2022

Why

Link looks bad on the first visit, but looks ok after :visited (likely why it was not spotted before), open in incognito mode to test, screenshots below.

Before:
Screenshot 2022-02-25 at 16 55 45

After:
Screenshot 2022-02-25 at 17 04 34

What

Small CSS change, unsure if there would be a preferred :visited colour and default colour?

Checklist

  • [ N/A ] Documentation updated
  • [ N/A ] Demo added
  • [ X ] Ready to be merged

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/4F9ZFL8Kvg7i8ivTaYP7GhSuk8cz
✅ Preview: https://react-spring-io-git-fork-fasani-fix-link-color-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f83eea:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
spring-cards-stack Configuration
spring-chain Configuration
spring-css-keyframes Configuration
spring-draggable-list Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 37e33a3 into pmndrs:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants