support removing attributes from animated elements (try 2) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0763287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
joshuaellis
reviewed
Oct 4, 2024
| instance.setAttribute(name, value) | ||
| } else { | ||
| instance.removeAttribute(name) | ||
| } | ||
| }) | ||
|
|
||
| if (className !== void 0) { |
There was a problem hiding this comment.
should we apply the same logic of removing to all the props here? Just wondering the rationale behind the ones you've changed at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
inertdoes not acceptinert='',inert='false',inert='undefined'or etc. The attribute must be entirely removed in order to enable the element again.disabledworks the same way.What
If a value resolves to
undefined(notnullorfalseor otherwise) its attribute will now be entirely removed.Checklist