Fix: don't call useTransition's update lifecycle if items are the same #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "config" prop of useSpring is used as the default "config" of any async updates which have no explicit "config"
The `_stopAnimation` method is called whenever a new key is animated, which updates the `timestamps` map. There was a race condition where the `now()` function could return a number that was 1ms greater than the timestamp used for the entire `update` call.
In addition to "config", now the "immediate", "reset", and "reverse" props only apply for one update. Also, the "immediate" prop of useSpring is used as the default when an update has no explicit "immediate" prop.
A prop should be updated if the timestamps are equal.
Not just "string" or "number"
The "to" and "from" props are now swapped before diffing. This means `this.props` will always be up-to-date.
It is very important to call `setValue(fromValue)` before `reset(isActive)`, because the `reset` method sets the `startPosition` and `lastPosition` properties to the current `value`.
Never return null. Stop warning about non-animatable values, since they are perfectly legal.
The "attach" prop must be false when no controller should be attached to. Instead, it was undefined, so it was ignored by the diffing algorithm. This meant that when `reverse` turned false from true, the last controller stayed attached to the 2nd-to-last controller when it should have been the "leader of the pack".
|
Please, give me some feedback. I also want to add extraKeys as described: But I need to know that this conception is OK. At least, in my project it is a silver bullet and, I suppose, many developers would like to have such an ability from the box. |
aleclarson
force-pushed
the
v9
branch
6 times, most recently
from
bb2243d to
1fabc92
Compare
aleclarson
force-pushed
the
v9
branch
4 times, most recently
from
8603b25 to
d34f09e
Compare
aleclarson
force-pushed
the
v9
branch
4 times, most recently
from
825aba8 to
2261d9b
Compare
|
So basically, users would memoize the I think memoizing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my comments on #621.
This small fix makes useTransition work as expected:
if we don't update items props, it shouldn't call update.
Indispensable fix for functional components that have more than one prop. At the same time, the solution might not be the best one so wait your comments.