fix(types): @react-three/drei declaration files #2478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the @react-three/drei declaration files fail to type-check with these errors:
Errors
These errors are occurring because
NonFunctionKeys
is a homomorphic mapped type and therefore it will includeundefined
if any of the object properties are optional. The best way to fix this error is to remove the optional-ness of the properties when performing the mapping as demonstrated in this PR. See microsoft/TypeScript#34992 for more details why TypeScript includesundefined
in the keys produced by theNonFunctionKeys
mapping without this fix.