[v9] refactor(types): export public types #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyJasonBennett
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 12fbd11:
|
packages/fiber/src/core/stages.ts
Outdated
| export interface UpdateCallback { | ||
| (state: RootState, delta: number, frame?: XRFrame): void | ||
| } | ||
|
|
||
| export type UpdateCallbackRef = MutableRefObject<UpdateCallback> | ||
| type Store = UseBoundStore<RootState, StoreApi<RootState>> | ||
| export type UpdateSubscription = { ref: UpdateCallbackRef; store: Store } | ||
|
|
||
| export type FixedStageOptions = { fixedStep?: number; maxSubsteps?: number } | ||
| export type FixedStageProps = { fixedStep: number; maxSubsteps: number; accumulator: number; alpha: number } | ||
| // TODO: Remove deprecated fields in `Subscription` | ||
| export type UpdateSubscription = Omit<Subscription, 'priority'> |
There was a problem hiding this comment.
I didn't see use of FixedStageOptions or FixedStageProps anywhere, but what's going on with UpdateCallback and RenderCallback? Should we alias or rename/depreciate them?
CodyJasonBennett
requested review from
krispya,
drcmda and
joshuaellis
and removed request for
krispya and
drcmda
Comment on lines
4
to
8
|
|
||
| type GlobalRenderCallback = (timeStamp: number) => void | ||
| export type GlobalRenderCallback = (timestamp: number) => void | ||
| type SubItem = { callback: GlobalRenderCallback } | ||
|
|
||
| function createSubs(callback: GlobalRenderCallback, subs: Set<SubItem>): () => void { |
There was a problem hiding this comment.
This should be backported to v8 in a patch release. We didn't actually export anything in #2481.
joshuaellis
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports public-facing types from the core, namely events and state keys.