Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): add back ReactThreeFiber namespace, math types #2674

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented Dec 19, 2022

Continues #2672. Related: #2668.

@CodyJasonBennett
Copy link
Member Author

Need to double check Layers' usage.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c01824:

Sandbox Source
example Configuration

@krispya
Copy link
Member

krispya commented Dec 19, 2022

Need to double check Layers' usage.

What do you mean by Layer usage? I can check some cases for you.

@CodyJasonBennett
Copy link
Member Author

CodyJasonBennett commented Dec 19, 2022

I'm not sure how to use it, we have no coverage for it in tests for applyProps and don't want it to slip.

@krispya
Copy link
Member

krispya commented Dec 19, 2022

@krispya
Copy link
Member

krispya commented Dec 31, 2022

Following up on this. It looks good in my basic tests so far, but I have not tested layers.

@CodyJasonBennett
Copy link
Member Author

Looks like master resolves to number | THREE.Layers, accepting a scalar type rather than a single element array. This would be more correct.

image

@CodyJasonBennett CodyJasonBennett merged commit 0df10bb into v9 Dec 31, 2022
@CodyJasonBennett CodyJasonBennett deleted the chore/types-namespace branch December 31, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants