fix: memoize HMR, strict check constructors

[drcmda]

for reference #2755

breaks testing, it relied on memoprops being present but tracking the logic gets too wired up. @joshuaellis do you remember what that was for?

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff538dd:

Sandbox	Source
example	Configuration

[joshuaellis]

It's needed for a test renderer. It's also used in react-dom - so I don't think we should remove it...

I didn't know it was being used at much in the r3f reconciler?

[joshuaellis]

In a few lines, what's the issue we're trying to solve here? 🤔

[CodyJasonBennett]

LocalState['memoizedProps'] is unrelated to #2755, but it was only used for HMR in R3F before this PR. bce99ae refactors RTTR to read prop values from the underlying fiber which is more correct, but if this is technically a breaking change (see snapshot diff), we can keep LocalState['memoizedProps'] as is and relegate this to v9 which already mirrors the Fiber['memoizedProps'] behavior. Alternatively, the new getMemoizedProps helper of RTTR can be inlined as a lazy getter on LocalState['memoizedProps'].

[joshuaellis]

LocalState['memoizedProps'] is unrelated to #2755, but it was only used for HMR in R3F before this PR. bce99ae refactors RTTR to read prop values from the underlying fiber which is more correct, but if this is technically a breaking change (see snapshot diff), we can keep LocalState['memoizedProps'] as is and relegate this to v9 which already mirrors the Fiber['memoizedProps'] behavior. Alternatively, the new getMemoizedProps helper of RTTR can be inlined as a lazy getter on LocalState['memoizedProps'].

We could omit attach though right? 🤔 By adding it to this line

That would solve part of the issue of potential breaking changes?

[joshuaellis]

Really great work both of you ⭐

[CodyJasonBennett]

WRT #2755 (comment), we may want to keep memoizedProps but only as a getter for the current getMemoizedProps in RTTR until v9.