Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treeshake THREE.ColorManagement #2798

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented Mar 6, 2023

Fixes #2794

Removes dynamic expressions around the THREE namespace to permit tree-shaking. Since THREE.ColorManagement is an optional global in v8 (we implement a fallback), I've opted to access it from the internal catalogue. We'll bump the three peer dep to >=139 in v9 so we can simply do THREE.ColorManagement and in accordance with breaking changes in the types.

@CodyJasonBennett CodyJasonBennett marked this pull request as draft March 6, 2023 14:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 65517ed:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett marked this pull request as ready for review March 6, 2023 14:31
@CodyJasonBennett CodyJasonBennett merged commit 63e9da5 into master Mar 6, 2023
@CodyJasonBennett CodyJasonBennett deleted the fix/treeshake-colormanagement branch March 6, 2023 14:43
renovate bot referenced this pull request in ziyadedher/ziyadedher Mar 7, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.8` ->
`8.11.9`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.8/8.11.9)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/compatibility-slim/8.11.8)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/confidence-slim/8.11.8)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.9`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/8.11.9)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.8...8.11.9)

#### What's Changed

- fix: treeshake THREE.ColorManagement by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2798](https://togithub.com/pmndrs/react-three-fiber/pull/2798)

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.8...8.11.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher referenced this pull request in ziyadedher/ziyadedher Dec 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.8` ->
`8.11.9`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.8/8.11.9)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/compatibility-slim/8.11.8)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.9/confidence-slim/8.11.8)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.9`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/8.11.9)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.8...8.11.9)

#### What's Changed

- fix: treeshake THREE.ColorManagement by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2798](https://togithub.com/pmndrs/react-three-fiber/pull/2798)

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.8...8.11.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
itsdouges pushed a commit to itsdouges/react-three-fiber that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree shaking doesn't work
1 participant