Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: TS Typings #1

Merged
merged 65 commits into from
Mar 3, 2021
Merged

WIP: TS Typings #1

merged 65 commits into from
Mar 3, 2021

Conversation

giulioz
Copy link
Member

@giulioz giulioz commented Feb 24, 2021 •
edited
Loading

Closes #4

@giulioz giulioz changed the title WIP: TS Typings WIP: TS Typings #4 Feb 25, 2021
@giulioz giulioz changed the title WIP: TS Typings #4 WIP: TS Typings Feb 25, 2021
@joshuaellis
Copy link
Member

Hey @giulioz, would you mind adding the eslint config from drei and setting that up? 🙏🏼

@DylanTackoor
Copy link
Contributor

@joshuaellis I just made an attempt at importing the drei eslint config, I'll make a PR into this branch shortly 😄

@DylanTackoor DylanTackoor mentioned this pull request Feb 27, 2021
Merged
@DylanTackoor
Copy link
Contributor

Seeing that FirstPersonControls.js hasn't gotten an update yet, cool if I try converting it?

@giulioz
Copy link
Member Author

giulioz commented Feb 27, 2021

@DylanTackoor yeah go ahead if you want :)

@joshuaellis joshuaellis added this to the TS Transition stage 1 milestone Feb 27, 2021
@drcmda
Copy link
Member

drcmda commented Feb 28, 2021 •
edited
Loading

@giulioz do we merge little by little or as a whole? there are some changes still made to the js files, does that complicate things for you? controls currently have side effects in the constructor which is a no go, they should add event listeners in a manual connect function. see mrdoob/three.js#21224 should i make this change now to the js files or in here?

@joshuaellis joshuaellis mentioned this pull request Feb 28, 2021
Merged
1 task
joshuaellis and others added 26 commits March 1, 2021 19:20
@joshuaellis
feat: add TrackballControls
dd66580
@joshuaellis
feat: add transform controls
f59f1e2
@joshuaellis
fix: domElement can be null, add checkers
b9ceb5a
@giulioz
Removed some private variables in DeviceOrientationControls
0a4dbd5
@giulioz
Refactored FPC
db0d12d
@giulioz
Refactored DragControls
6e81bba
@DylanTackoor @giulioz
initial typings CameraControls
22562c0
@DylanTackoor @giulioz
changes CameraControl class comments to jsdoc
26ea3f0
@DylanTackoor @giulioz
moar TS
e89c1d6
@DylanTackoor @giulioz
WIP private method updates
dfa6657
@DylanTackoor @giulioz
converts remaning private methods
929d1ab
@DylanTackoor @giulioz
converts event callbacks
9a20e64
@DylanTackoor @giulioz
type + comment cleanup
a94f0c3
@DylanTackoor @giulioz
properly types CameraControls.object
34c20fa
@DylanTackoor @giulioz
removes unused interface + CameraControl.js
586d930
@DylanTackoor @giulioz
Revert "removes unused interface + CameraControl.js"
f366596 
This reverts commit b9aa92b.
@DylanTackoor @giulioz
removes only the js file 🤦
1fc61f9
@DylanTackoor @giulioz
adds fixme comments for when i can get back to this
6867302
@DylanTackoor @giulioz
resolves FIXMEs
2588fc4
@DylanTackoor @giulioz
CameraControls.update cleanup
f613479
@DylanTackoor @giulioz
simplifies pan/panUp/panLeft
7e75cc5
@DylanTackoor @giulioz
last CameraControls.ts type fixes
613dd32
@DylanTackoor @giulioz
moves most CameraControls prop initialization out of constructor
633b94a
@DylanTackoor @giulioz
converts some comments to tsdoc + fixes fixes mouseButtons types by m…
fd6002a 
…oving back into controller for rn
@DylanTackoor
simplifies PointerLockControls.getDirection()
cd40115
@joshuaellis
refactor: simplifies PointerLockControls.getDirection()
e940311 
simplifies PointerLockControls.getDirection()
joshuaellis
joshuaellis approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, OrbitControls is a mind blower, lets leave that for now 👀

@joshuaellis joshuaellis merged commit 8c73f17 into main Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drcmda drcmda drcmda left review comments

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
TS Transition stage 1
Development

Successfully merging this pull request may close these issues.

[TS1] Move Controls to TS
5 participants
@giulioz @joshuaellis @DylanTackoor @drcmda @RenaudRohlinger