fix: BufferGeometry rename uv2 to uv1

[RodrigoHamuy]

uv2 has been renamed to uv1 in threejs:

• BufferGeometry: Renamed uv2, uv3, uv4 to uv1, uv2, uv3 mrdoob/three.js#25943

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[CodyJasonBennett]

We'll need to perform some indirection here for the key to preserve backward compatibility. Had a tough time maintaining this with the back-to-back renames between versions.

three-stdlib/src/loaders/GLTFLoader.js

Lines 1753 to 1770 in d89e3c3

	const ATTRIBUTES = {
	POSITION: 'position',
	NORMAL: 'normal',
	TANGENT: 'tangent',
	// uv => uv1, 4 uv channels
	// https://github.com/mrdoob/three.js/pull/25943
	// https://github.com/mrdoob/three.js/pull/25788
	...(version >= 152
	? {
	TEXCOORD_0: 'uv',
	TEXCOORD_1: 'uv1',
	TEXCOORD_2: 'uv2',
	TEXCOORD_3: 'uv3',
	}
	: {
	TEXCOORD_0: 'uv',
	TEXCOORD_1: 'uv2',
	}),

[RodrigoHamuy]

@CodyJasonBennett I think is not a terrible idea to ask users to update to a newer ThreeJS version that is more than a year old anyway in exchange of cleaner code.

But if you disagree, will update the files to follow the same strategy as GLTFLoader.js for backward compatiliby.

[CodyJasonBennett]

The goal of this project is to make itself obsolete by fostering improvements to three examples, and upstreaming them, but we have the additional constraint of adhering to SemVer (which I personally think is an oversight) which means we have to employ tricks to maintain compatibility.

Requiring an upgrade to three.js is a breaking change (major version increment), and I think we can try to maintain an indirection table until that becomes infeasible. The need for an upgrade to three.js is a larger conversation than the changes in this PR alone, as we support as low as r128 with many breaking changes to public API and types since.

[CodyJasonBennett]

I can do this myself in a few hours, when I can take a closer look.

[RodrigoHamuy]

I can do this myself in a few hours, when I can take a closer look.

No worries, makes sense, will push in a few minutes.

[RodrigoHamuy]

@CodyJasonBennett backward compatibility added ☺️

[CodyJasonBennett]

Thanks; I appreciate the thoroughness. Elevating to a fix so we can get this out.

[github-actions]

🎉 This PR is included in version 2.32.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀