Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/626 #627

Merged
merged 5 commits into from
Sep 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-bottles-hear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@use-gesture/core': minor
---

Fix: touch support is reverted to only checking TouchEvent support #626
4 changes: 2 additions & 2 deletions .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node
uses: actions/setup-node@v3
Expand All @@ -25,7 +25,7 @@ jobs:

- uses: pnpm/action-setup@v2
with:
version: 8.3.1
version: 8
run_install: true

- name: Build documentation
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node
uses: actions/setup-node@v3
Expand All @@ -37,7 +37,7 @@ jobs:

- uses: pnpm/action-setup@v2
with:
version: 8.3.1
version: 8
run_install: |
args: [--filter "@use-gesture/*"]

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout code repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -34,7 +34,7 @@ jobs:

- uses: pnpm/action-setup@v2
with:
version: 8.3.1
version: 8
run_install: |
args: [--filter "@use-gesture/*"]

Expand Down
8 changes: 4 additions & 4 deletions demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
},
"devDependencies": {
"@types/lodash.clamp": "^4.0.7",
"@types/react": "^18.0.24",
"@types/react-dom": "^18.0.8",
"@types/react": "^18.2.21",
"@types/react-dom": "^18.2.7",
"@types/three": "^0.140.0",
"@vitejs/plugin-react": "^3.1.0",
"typescript": "^5.0.4",
"typescript": "^5.2.2",
"typescript-plugin-css-modules": "^5.0.1",
"vite": "^4.2.1"
"vite": "^4.4.9"
}
}
2 changes: 1 addition & 1 deletion documentation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"gatsby-plugin-google-analytics": "^4.24.0",
"gatsby-plugin-pnpm": "^1.2.10",
"lethargy": "^1.0.9",
"leva": "^0.9.25",
"leva": "^0.9.35",
"mdx-observable": "^0.2.0",
"parse-numeric-range": "^1.3.0",
"react": "^18.2.0",
Expand Down
38 changes: 19 additions & 19 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,41 +73,41 @@
]
},
"devDependencies": {
"@babel/core": "^7.21.8",
"@babel/plugin-syntax-flow": "^7.21.4",
"@babel/plugin-transform-react-jsx": "^7.21.5",
"@babel/preset-env": "^7.21.5",
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.21.5",
"@changesets/cli": "^2.26.1",
"@preconstruct/cli": "^2.7.0",
"@babel/core": "^7.22.19",
"@babel/plugin-syntax-flow": "^7.22.5",
"@babel/plugin-transform-react-jsx": "^7.22.15",
"@babel/preset-env": "^7.22.15",
"@babel/preset-react": "^7.22.15",
"@babel/preset-typescript": "^7.22.15",
"@changesets/cli": "^2.26.2",
"@preconstruct/cli": "^2.8.1",
"@size-limit/preset-small-lib": "^7.0.8",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.2.0",
"@types/jest": "^27.5.1",
"@types/node": "^20.2.1",
"@types/react": "^18.2.6",
"@types/react-dom": "^18.2.4",
"@typescript-eslint/eslint-plugin": "^5.59.6",
"@typescript-eslint/parser": "^5.59.6",
"@types/jest": "^27.5.2",
"@types/node": "^20.6.2",
"@types/react": "^18.2.21",
"@types/react-dom": "^18.2.7",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"babel-jest": "^29.4.1",
"eslint": "^8.41.0",
"eslint-config-prettier": "^8.6.0",
"eslint": "^8.49.0",
"eslint-config-prettier": "^8.10.0",
"eslint-config-react-app": "^7.0.1",
"eslint-plugin-jest-dom": "^4.0.3",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-testing-library": "^5.10.0",
"eslint-plugin-testing-library": "^5.11.1",
"husky": "^8.0.3",
"jest": "^27.5.1",
"pnpm": "^8.5.1",
"pnpm": "^8.7.5",
"postinstall-postinstall": "^2.1.0",
"prettier": "^2.8.8",
"pretty-quick": "^3.1.3",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"size-limit": "^7.0.8",
"tsd": "^0.28.1",
"typescript": "^5.0.4"
"typescript": "^5.2.2"
},
"lint-staged": {
"*.js": "eslint --cache --fix",
Expand Down
8 changes: 6 additions & 2 deletions packages/core/src/config/support.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,13 @@ export const SUPPORT = {
* some touchscreens using webkits don't have 'ontouchstart' in window. So
* we're considering that browsers support TouchEvent if they have
* `maxTouchPoints > 1`
*
* Update 16/09/2023: This generates failure on other Windows systems, so reverting
* back to detecting TouchEvent support only.
* https://github.com/pmndrs/use-gesture/issues/626
*/
// touch: supportsTouchEvents(),
touch: isTouchScreen(),
touch: supportsTouchEvents(),
// touch: isTouchScreen(),
touchscreen: isTouchScreen(),
pointer: supportsPointerEvents(),
pointerLock: supportsPointerLock()
Expand Down
Loading