Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer function declaration #359

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 11, 2022

...to allow declaration merging.

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/valtio/825jxNXzW1fo2Z9vB41wbuXew5Fc
✅ Preview: https://valtio-git-refactor-prefer-function-declaration-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 569cf82:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

github-actions bot commented Feb 11, 2022

Size Change: +152 B (0%)

Total Size: 45.7 kB

Filename Size Change
dist/esm/index.js 1.36 kB +8 B (+1%)
dist/esm/utils.js 3.91 kB +19 B (0%)
dist/esm/vanilla.js 1.85 kB +13 B (+1%)
dist/index.js 1.44 kB -1 B (0%)
dist/system/index.development.js 1.55 kB +4 B (0%)
dist/system/index.production.js 874 B +10 B (+1%)
dist/system/utils.development.js 4.12 kB +33 B (+1%)
dist/system/utils.production.js 2.75 kB +31 B (+1%)
dist/system/vanilla.development.js 1.97 kB +30 B (+2%)
dist/system/vanilla.production.js 1.25 kB +13 B (+1%)
dist/umd/index.development.js 1.55 kB -2 B (0%)
dist/umd/utils.development.js 4.66 kB -3 B (0%)
dist/umd/utils.production.js 2.95 kB +7 B (0%)
dist/umd/vanilla.development.js 2.06 kB -2 B (0%)
dist/umd/vanilla.production.js 1.31 kB -1 B (0%)
dist/utils.js 4.53 kB -3 B (0%)
dist/vanilla.js 1.95 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/macro.js 613 B
dist/macro.js 910 B
dist/system/macro.development.js 721 B
dist/system/macro.production.js 556 B
dist/umd/index.production.js 990 B
dist/umd/macro.development.js 1.06 kB
dist/umd/macro.production.js 766 B

compressed-size-action

@dai-shi dai-shi merged commit 244fc3f into main Feb 12, 2022
@dai-shi dai-shi deleted the refactor/prefer-function-declaration branch February 12, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant