Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove __DEV__ with ts-jest #643

Merged
merged 44 commits into from
Feb 4, 2023
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 29, 2023

__DEV__ is blocking Deno support.

  • produce almost the same output
  • fix tests

First tried to use swc/jest to produce ESM, but was unsuccessful. Using ts-jest works fine. Besides, new ts-jest seems fast with esbuild.

@vercel
Copy link

vercel bot commented Jan 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
valtio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 3:22PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04c5203:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

github-actions bot commented Jan 29, 2023

Size Change: +9 B (0%)

Total Size: 55.3 kB

Filename Size Change
dist/macro.js 937 B -2 B (0%)
dist/macro/vite.js 1.09 kB -1 B (0%)
dist/react.js 652 B -1 B (0%)
dist/umd/vanilla/utils.development.js 4.68 kB +17 B (0%)
dist/vanilla.js 2.47 kB -1 B (0%)
dist/vanilla/utils.js 4.51 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 710 B
dist/esm/react/utils.js 221 B
dist/esm/utils.js 68 B
dist/esm/vanilla.js 2.27 kB
dist/esm/vanilla/utils.js 4.18 kB
dist/index.js 232 B
dist/react/utils.js 237 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 851 B
dist/system/react.production.js 466 B
dist/system/react/utils.development.js 316 B
dist/system/react/utils.production.js 221 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla.development.js 2.4 kB
dist/system/vanilla.production.js 1.45 kB
dist/system/vanilla/utils.development.js 4.4 kB
dist/system/vanilla/utils.production.js 2.92 kB
dist/umd/index.development.js 372 B
dist/umd/index.production.js 322 B
dist/umd/macro.development.js 1.05 kB
dist/umd/macro.production.js 724 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 882 B
dist/umd/react.development.js 797 B
dist/umd/react.production.js 519 B
dist/umd/react/utils.development.js 396 B
dist/umd/react/utils.production.js 297 B
dist/umd/utils.development.js 386 B
dist/umd/utils.production.js 333 B
dist/umd/vanilla.development.js 2.58 kB
dist/umd/vanilla.production.js 1.52 kB
dist/umd/vanilla/utils.production.js 3 kB
dist/utils.js 236 B

compressed-size-action

@dai-shi dai-shi changed the title choe: remove __DEV__ with ts-jest chore: remove __DEV__ with ts-jest Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Size Change: +9 B (0%)

Total Size: 55.3 kB

Filename Size Change
dist/macro.js 937 B -2 B (0%)
dist/macro/vite.js 1.09 kB -1 B (0%)
dist/react.js 652 B -1 B (0%)
dist/umd/vanilla/utils.development.js 4.68 kB +17 B (0%)
dist/vanilla.js 2.47 kB -1 B (0%)
dist/vanilla/utils.js 4.51 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 710 B
dist/esm/react/utils.js 221 B
dist/esm/utils.js 68 B
dist/esm/vanilla.js 2.27 kB
dist/esm/vanilla/utils.js 4.18 kB
dist/index.js 232 B
dist/react/utils.js 237 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 851 B
dist/system/react.production.js 466 B
dist/system/react/utils.development.js 316 B
dist/system/react/utils.production.js 221 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla.development.js 2.4 kB
dist/system/vanilla.production.js 1.45 kB
dist/system/vanilla/utils.development.js 4.4 kB
dist/system/vanilla/utils.production.js 2.92 kB
dist/umd/index.development.js 372 B
dist/umd/index.production.js 322 B
dist/umd/macro.development.js 1.05 kB
dist/umd/macro.production.js 724 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 882 B
dist/umd/react.development.js 797 B
dist/umd/react.production.js 519 B
dist/umd/react/utils.development.js 396 B
dist/umd/react/utils.production.js 297 B
dist/umd/utils.development.js 386 B
dist/umd/utils.production.js 333 B
dist/umd/vanilla.development.js 2.58 kB
dist/umd/vanilla.production.js 1.52 kB
dist/umd/vanilla/utils.production.js 3 kB
dist/utils.js 236 B

compressed-size-action

This reverts commit 7afd77d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant