Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation of proxyMap and proxySet with performance improvements #965

Merged
merged 170 commits into from
Oct 16, 2024

Conversation

overthemike
Copy link
Collaborator

@overthemike overthemike commented Oct 13, 2024

Related Bug Reports or Discussions

#943

Summary

Improvements:

  • performance improvements from O(n) to O(log n) for both proxyMap and proxySet

proxySet now has new Set methods:

  • intersection
  • isDisjointFrom
  • isSubsetOf
  • isSupersetOf
  • symmetricDifference
  • union

Fixed some previously unknown bugs with old implementations and added some new tests.

Check List

  • pnpm run prettier for formatting code and docs

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the final review.

src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do the same.

src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxySet.ts Outdated Show resolved Hide resolved
@overthemike overthemike changed the title Keyed collections New implementation of proxyMap and proxySet with performance improvements Oct 16, 2024
@dai-shi dai-shi marked this pull request as ready for review October 16, 2024 01:13
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dai-shi dai-shi merged commit 131df82 into main Oct 16, 2024
29 checks passed
@dai-shi dai-shi deleted the keyed-collections branch October 16, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants