with immer midderware, Array type wrong

[alpacachen]

an immer store, can't use Arrray.sort, but TS check escaped.

Error in /~/src/App.tsx (23:62)
Cannot assign to read only property '0' of object '[object Array]'

demo : https://stackblitz.com/edit/stackblitz-starters-ebbhts?file=src/App.tsx

hope TS checker can emit error correctly

[dai-shi]

Is it push instead of sort in the demo?

[dai-shi]

Oh, I found it commented out.

So, is it a typescript issue? Or, a runtime issue?

[alpacachen]

runtime issue，in demo ，click inc button twice，can getthe error

[alpacachen]

I think its better to expose error during ts
Check

[dai-shi]

https://codesandbox.io/s/zealous-hodgkin-k3f6nz?file=/src/App.tsx
Disabling auto freeze seems to work around.

[dai-shi]

Or, copy the array.
https://codesandbox.io/s/dreamy-brahmagupta-448h98

[dai-shi]

Not sure if anything can be done on zustand end.
Please feel free to investigate it if anyone is interested.

Here's the code without types: https://unpkg.com/browse/zustand@4.4.4/esm/middleware/immer.mjs

[alpacachen]

Or, copy the array. https://codesandbox.io/s/dreamy-brahmagupta-448h98

Im not sure its a good way,because i can not Ask my colleagues to do the same

[alpacachen]

https://codesandbox.io/s/zealous-hodgkin-k3f6nz?file=/src/App.tsx Disabling auto freeze seems to work around.

this is the good way

[alpacachen]

https://immerjs.github.io/immer/typescript#best-practices

Immer Best practices