Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] add spec with ssr #903

Closed
dai-shi opened this issue Apr 10, 2022 · 6 comments · Fixed by #2088
Closed

[test] add spec with ssr #903

dai-shi opened this issue Apr 10, 2022 · 6 comments · Fixed by #2088
Assignees
@NaamuKim
Labels
help wanted Please someone help on this

Comments

@dai-shi
Copy link
Member

dai-shi commented Apr 10, 2022

#886 was reported and fixed, but we don't have a test for it.

reduxjs/react-redux#1888 can be a good reference.
@dai-shi dai-shi added the help wanted Please someone help on this label Apr 10, 2022
@amareshsm
Copy link

I would like to give it a try. I might need some time to complete it. Can I pick this?

@dai-shi
Copy link
Member Author

dai-shi commented May 25, 2022

sure thing!

@arnaugomez
Copy link

Hi, because more than a year has passed since last activity, I will give it a try and make a PR

@qqqzhch
Copy link

qqqzhch commented Aug 29, 2023

This is to write a demo, such as using zustand in next13？

@dai-shi
Copy link
Member Author

dai-shi commented Aug 29, 2023

This is about adding a new test in https://github.com/pmndrs/zustand/tree/main/tests.

@NaamuKim
Copy link
Contributor

@dai-shi I would like to adding a test for this issue.
Can you assign me?
I will upload the PR before October 3rd.

NaamuKim added a commit to NaamuKim/zustand that referenced this issue Sep 28, 2023
@NaamuKim
test(ssr): Validate state synchronization between server and client i…
1054671 
…n React 18 using Zustand (pmndrs#903)
NaamuKim added a commit to NaamuKim/zustand that referenced this issue Sep 28, 2023
@NaamuKim
test(ssr): Validate state synchronization between server and client i…
c85fc59 
…n React 18 using Zustand (pmndrs#903)
@NaamuKim NaamuKim mentioned this issue Sep 28, 2023
Merged
1 task
NaamuKim added a commit to NaamuKim/zustand that referenced this issue Oct 2, 2023
@NaamuKim
test(ssr): Validate state synchronization between server and client i…
1cda729 
…n React 18 using Zustand (pmndrs#903)
dai-shi added a commit to NaamuKim/zustand that referenced this issue Oct 2, 2023
@dai-shi
Merge branch 'main' into test/pmndrs#903-add-spec-with-ssr
24da89c
@dai-shi dai-shi linked a pull request Oct 2, 2023 that will close this issue
test(ssr): Validate state synchronization between server and client in React 18 using Zustand (#903) #2088
Merged
1 task
dai-shi added a commit that referenced this issue Oct 2, 2023
@NaamuKim @dai-shi
test(ssr): Validate state synchronization between server and client i…
1e846b3 
…n React 18 using Zustand (#903) (#2088)

* test(ssr): Validate state synchronization between server and client in React 18 using Zustand (#903)

* test(ssr): dynamically import hydrateRoot for React 18 and skip if version < 18

* test(ssr): implement conditional describe based on React version

* test(ssr): Refactor SSR code using skipIf and importActual

* test(ssr): Refactor code using 'importActual' with a more specific type for 'hydrateRoot'

* test(ssr): remove async from the main test function

---------

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NaamuKim NaamuKim

Labels
help wanted Please someone help on this
Projects
None yet
Milestone
No milestone
5 participants
@dai-shi @qqqzhch @amareshsm @arnaugomez @NaamuKim