fix: importing CJS React in ESM

[dai-shi]

Related Issues or Discussions

Fixes #1395 (comment)

Summary

To avoid errors when Zustand is used on server as ESM.

Check List

• yarn run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zustand-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2023 0:55am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b7ff8d:

Sandbox	Source
React	Configuration
React TypeScript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
Next.js	Configuration
@pavlobu/zustand demo	Configuration

[github-actions]

Size Change: +278 B (+1%)

Total Size: 52.4 kB

Filename	Size	Change
dist/context.js	820 B	+38 B (+5%)	🔍
dist/esm/context.js	612 B	+22 B (+4%)
dist/esm/index.js	717 B	+11 B (+2%)
dist/esm/react/shallow.js	479 B	+18 B (+4%)
dist/esm/traditional.js	400 B	+8 B (+2%)
dist/index.js	874 B	+6 B (+1%)
dist/react/shallow.js	1.07 kB	+14 B (+1%)
dist/system/context.development.js	694 B	-3 B (0%)
dist/system/context.production.js	390 B	+4 B (+1%)
dist/system/index.development.js	881 B	+8 B (+1%)
dist/system/index.production.js	407 B	+5 B (+1%)
dist/system/react/shallow.development.js	577 B	+22 B (+4%)
dist/system/react/shallow.production.js	400 B	+10 B (+3%)
dist/system/traditional.development.js	514 B	+9 B (+2%)
dist/system/traditional.production.js	348 B	+6 B (+2%)
dist/traditional.js	443 B	+10 B (+2%)
dist/umd/context.development.js	928 B	+41 B (+5%)	🔍
dist/umd/context.production.js	568 B	+12 B (+2%)
dist/umd/index.development.js	1 kB	+5 B (+1%)
dist/umd/index.production.js	546 B	+3 B (+1%)
dist/umd/react/shallow.development.js	1.21 kB	+11 B (+1%)
dist/umd/react/shallow.production.js	895 B	+1 B (0%)
dist/umd/traditional.development.js	625 B	+12 B (+2%)
dist/umd/traditional.production.js	452 B	+5 B (+1%)

ℹ️ View Unchanged

Filename	Size
dist/esm/middleware.js	3.87 kB
dist/esm/middleware/immer.js	210 B
dist/esm/shallow.js	511 B
dist/esm/vanilla.js	629 B
dist/esm/vanilla/shallow.js	366 B
dist/middleware.js	4.44 kB
dist/middleware/immer.js	328 B
dist/shallow.js	1.11 kB
dist/system/middleware.development.js	4 kB
dist/system/middleware.production.js	2.62 kB
dist/system/middleware/immer.development.js	292 B
dist/system/middleware/immer.production.js	187 B
dist/system/shallow.development.js	559 B
dist/system/shallow.production.js	345 B
dist/system/vanilla.development.js	672 B
dist/system/vanilla.production.js	310 B
dist/system/vanilla/shallow.development.js	441 B
dist/system/vanilla/shallow.production.js	322 B
dist/umd/middleware.development.js	4.59 kB
dist/umd/middleware.production.js	2.97 kB
dist/umd/middleware/immer.development.js	482 B
dist/umd/middleware/immer.production.js	342 B
dist/umd/shallow.development.js	1.23 kB
dist/umd/shallow.production.js	883 B
dist/umd/vanilla.development.js	800 B
dist/umd/vanilla.production.js	410 B
dist/umd/vanilla/shallow.development.js	1.1 kB
dist/umd/vanilla/shallow.production.js	849 B
dist/vanilla.js	683 B
dist/vanilla/shallow.js	969 B

_{compressed-size-action}

[OlegLustenko]

@dai-shi it was incredibly fast!

So far, the fix looks good

tested:

• prod build Docker
• dev build local
• prod build local

However, I've got a weird issue in the dev build locally,
I'm not sure how this could be related to the changes made

I've got this error

When I only have page.tsx without layout.tsx on the same level

It wasn't the case for 4.4.4 version

Maybe this is a floating bug in Next.js 🤷‍♂️

[OlegLustenko]

@dai-shi I would go ahead and merge it. Are there any concerns about pushing it forward?

[dai-shi]

I'm not very confident if this causes some other unexpected issues, but let's proceed to know it.