Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: example/demo #2585

Merged
merged 2 commits into from
Jun 6, 2024
Merged

update: example/demo #2585

merged 2 commits into from
Jun 6, 2024

Conversation

sunil-sharma-999
Copy link
Contributor

Summary

  • fix eslint config and lint issues
  • fix react key issue
  • remove children passed as props
  • remove unused variables and imports
  • "encodings_fragment" is deprecated, replaced it with "colorspace_fragment"

Check List

  • pnpm run prettier for formatting code and docs
  • pnpm run test for test

@sunil-sharma-999
update: example/demo
b3b3cda 
- fix eslint config and lint issues
- fix react key issue
- remove children passed as props
- remove unused variables and imports
- "encodings_fragment" is deprecated, replaced it with "colorspace_fragment"
@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 0:20am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi
dai-shi reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

Would anyone like to give another review?

examples/demo/package.json Outdated Show resolved Hide resolved
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Member

dai-shi commented Jun 6, 2024

Would anyone like to give another review?

No one...

@dbritto-dev
Copy link
Collaborator

@sunil-sharma-999 @dai-shi LGTM

@dai-shi dai-shi merged commit 3b90e1c into pmndrs:main Jun 6, 2024
37 of 38 checks passed
@nouhaila49 nouhaila49 mentioned this pull request Jul 17, 2024
Closed
@kdsfkls kdsfkls mentioned this pull request Jul 17, 2024
Closed
@VladDudarenko VladDudarenko mentioned this pull request Jul 17, 2024
Closed
@zainaboladiti zainaboladiti mentioned this pull request Jul 17, 2024
Open
@AnnaTalan AnnaTalan mentioned this pull request Jul 17, 2024
Closed
@Sameer515 Sameer515 mentioned this pull request Jul 17, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jul 17, 2024
Open
@hunorszegediblack hunorszegediblack mentioned this pull request Jul 19, 2024
Open
@mewph mewph mentioned this pull request Jul 19, 2024
Open
@salzateatfluid salzateatfluid mentioned this pull request Jul 20, 2024
Closed
@bsd33bond bsd33bond mentioned this pull request Jul 20, 2024
Closed
@boduk000 boduk000 mentioned this pull request Jul 20, 2024
Closed
@basakerdogan basakerdogan mentioned this pull request Jul 24, 2024
Open
@luciano-mori luciano-mori mentioned this pull request Jul 24, 2024
Open
@gkchaitu63 gkchaitu63 mentioned this pull request Jul 30, 2024
Open
@jones58 jones58 mentioned this pull request Jul 30, 2024
Merged
@g00b g00b mentioned this pull request Jul 31, 2024
Closed
@aleksavic aleksavic mentioned this pull request Jul 31, 2024
Open
@z4ce z4ce mentioned this pull request Aug 1, 2024
Open
@filip-zaric filip-zaric mentioned this pull request Oct 1, 2024
Open
@kaustubhkarnik94 kaustubhkarnik94 mentioned this pull request Oct 1, 2024
Open
@devusvulgaris devusvulgaris mentioned this pull request Oct 3, 2024
Open
@antti-kyto antti-kyto mentioned this pull request Oct 3, 2024
Open
@perry7943 perry7943 mentioned this pull request Oct 3, 2024
Open
@hzdai0 hzdai0 mentioned this pull request Oct 6, 2024
Open
@jellyjams7 jellyjams7 mentioned this pull request Oct 6, 2024
Open
@tpaec01 tpaec01 mentioned this pull request Oct 6, 2024
Open
@blake91399 blake91399 mentioned this pull request Oct 6, 2024
Open
@Yes-Yes-Ye Yes-Yes-Ye mentioned this pull request Oct 6, 2024
Open
@joeltmenayathil joeltmenayathil mentioned this pull request Oct 6, 2024
Open
@gregdo21 gregdo21 mentioned this pull request Oct 9, 2024
Open
@voliverosv voliverosv mentioned this pull request Oct 19, 2024
Open
@Deus-Dox Deus-Dox mentioned this pull request Oct 19, 2024
Open
@pb-snyk pb-snyk mentioned this pull request Oct 20, 2024
Open
@FRA-37 FRA-37 mentioned this pull request Oct 23, 2024
Open
@kdsfkls kdsfkls mentioned this pull request Oct 23, 2024
Open
@skiiipy69 skiiipy69 mentioned this pull request Oct 26, 2024
Open
@shravyagoli26 shravyagoli26 mentioned this pull request Oct 26, 2024
Open
@Ilyas-snyk Ilyas-snyk mentioned this pull request Oct 27, 2024
Open
@VladDudarenko VladDudarenko mentioned this pull request Oct 27, 2024
Open
@snowsky snowsky mentioned this pull request Oct 28, 2024
Open
@saadawan-eng saadawan-eng mentioned this pull request Oct 29, 2024
Open
@nouhaila49 nouhaila49 mentioned this pull request Oct 30, 2024
Open
@foolcardssk foolcardssk mentioned this pull request Oct 30, 2024
Open
@thiagarajanb thiagarajanb mentioned this pull request Oct 30, 2024
Open
@Harshith5346 Harshith5346 mentioned this pull request Oct 31, 2024
Open
@cgonzo98 cgonzo98 mentioned this pull request Nov 1, 2024
Open
@realgoob realgoob mentioned this pull request Nov 1, 2024
Open
@ritwiksaha98 ritwiksaha98 mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunil-sharma-999 @dai-shi @dbritto-dev