Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persist): fix async migrate on persist middleware #2877

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

dbritto-dev
Copy link
Collaborator

Related Bug Reports or Discussions

Fixes #2827

Check List

  • pnpm run prettier for formatting code and docs

@dbritto-dev dbritto-dev added the bug Something isn't working label Dec 3, 2024
@dbritto-dev dbritto-dev requested a review from dai-shi December 3, 2024 01:15
@dbritto-dev dbritto-dev self-assigned this Dec 3, 2024
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:00pm

Copy link

codesandbox-ci bot commented Dec 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dbritto-dev dbritto-dev changed the title Fix async migrate fix(persist): fix async migrate on persist Dec 3, 2024
@dbritto-dev dbritto-dev changed the title fix(persist): fix async migrate on persist fix(persist): fix async migrate on persist middleware Dec 3, 2024
@KiwiKilian
Copy link

I tried to fix it way to complicated, looking good, thank you!

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise! Thanks for your work!

.github/workflows/test-multiple-builds.yml Outdated Show resolved Hide resolved
@dbritto-dev
Copy link
Collaborator Author

@dai-shi all yours

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dai-shi dai-shi added this to the v5.0.2 milestone Dec 4, 2024
@dbritto-dev
Copy link
Collaborator Author

@dai-shi jobs are stuck

@dai-shi dai-shi merged commit 9bae069 into pmndrs:main Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants