Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARMCI_Init_thread_comm #26

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

jeffhammond
Copy link
Member

requested by Eric Bylaska.

Signed-off-by: Hammond, Jeff R jeff.r.hammond@intel.com

requested by Eric Bylaska.

Signed-off-by: Hammond, Jeff R <jeff.r.hammond@intel.com>
Copy link
Collaborator

@jdinan jdinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change -- looks good to me. Would be nice to fix Travis failures, but it looks like the important cases are passing.

@jdinan
Copy link
Collaborator

jdinan commented Nov 5, 2019

It looks like there are some new build failures in Travis. Wonder if these are related, since they are in the same file modified by this PR?

src/init_finalize.c:43:21: error: variable has incomplete type 'struct timespec'
    struct timespec napstruct = { .tv_sec  = 0,
                    ^
src/init_finalize.c:43:12: note: forward declaration of 'struct timespec'
    struct timespec napstruct = { .tv_sec  = 0,
           ^
1 error generated.
Makefile:1706: recipe for target 'src/init_finalize.lo' failed
make: *** [src/init_finalize.lo] Error 1
The command "sh ./travis/build-run.sh $TRAVIS_ROOT $MPI_IMPL" exited with 2.

@jeffhammond
Copy link
Member Author

Yeah, I need to fix a lot of Travis issues in my open-source projects. Just haven't had time.

@jeffhammond jeffhammond mentioned this pull request Nov 5, 2019
@jeffhammond
Copy link
Member Author

@jdinan The struct timespec are stupid POSIX/BSD/ISO problems and I cannot reproduce locally. I will debug them in another branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants