romio: clean up file system detection #5671
Conversation
roblatham00
force-pushed
the
romio-stat-rework
branch
from
1f78ca1 to
59ea6ce
Compare
|
test:mpich/ch4/ofi |
|
huge big concern about portability -- this code represents 20+ years of porting across some platforms that don't even exist any longer. |
roblatham00
force-pushed
the
romio-stat-rework
branch
from
59ea6ce to
2950e6a
Compare
|
test:mpich/ch3/tcp |
roblatham00
force-pushed
the
romio-stat-rework
branch
from
2950e6a to
31247bb
Compare
|
test:mpich/ch3/tcp |
1 similar comment
|
test:mpich/ch3/tcp |
roblatham00
force-pushed
the
romio-stat-rework
branch
2 times, most recently
from
947db3b to
6020f3e
Compare
|
test:mpich/ch3/tcp |
roblatham00
force-pushed
the
romio-stat-rework
branch
from
6020f3e to
824b0b1
Compare
|
I was able to (eventually) build on OpenBSD, fixing a bug in the Because this code is so platform-specific and we have so few of the old platforms left to test on, I'd appreciate a second set of eyes from @wkliao (or anyone else) just to make sure I didn't miss anything obvious. |
roblatham00
force-pushed
the
romio-stat-rework
branch
from
824b0b1 to
88a3093
Compare
|
I still want to test this on a system with GPFS or Lustre to make sure we really do find GPFS or Lustre and I also want to test on OS X (it's BSD like but different enough). |
|
This looks fine with. |
roblatham00
force-pushed
the
romio-stat-rework
branch
2 times, most recently
from
c7fe9ee to
0c242f1
Compare
|
Tested and fixed on OSX (which is indeed different enough -- it has both 'f_fstypename' and a (reserved) fstype field. |
roblatham00
force-pushed
the
romio-stat-rework
branch
from
0c242f1 to
ddaaa46
Compare
|
test:mpich/ch3/most |
ROMIO file system checking had grown out of hand: - use AC_CHECK_MEMBERS instead of our ancient home-grown stat member checking logic. - abstract the "stat/statfs/statvfs" part from the rest of the code so we don't duplicate detection logic in three places - add a 'magic number' to the 'fstypes' struct so we can use that table multiple ways. check for more file systems
roblatham00
force-pushed
the
romio-stat-rework
branch
from
ddaaa46 to
f77d6f7
Compare
ROMIO file system checking had grown out of hand:
checking logic.
we don't duplicate detection logic in three places
Pull Request Description
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.