PMI: allow user to override PMI key value length #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/ofi |
hzhou
reviewed
May 23, 2024
| /* allowing user to override default KEY VAL size for certain system setups */ | ||
| MPL_env2int("PMI_MAX_KEY_SIZE", &pmi_max_key_size); | ||
| MPL_env2int("PMI_MAX_VAL_SIZE", &pmi_max_val_size); | ||
|
|
There was a problem hiding this comment.
There is question whether this is the true cause of the issue. Let's hold the PR until we understand better.
There was a problem hiding this comment.
Also, describe the actual changes in the commit message. The issue number is not github specific and not safe for downstreams.
There was a problem hiding this comment.
@yfguo Please refer to #6924 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes the #6924. The SDSC Expanse seems to have a long key value length that is not compatible with the MPICH default.
This PR does not depends on #7008. Only rebased on it because the formatting error is failing pre-commit hook.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.