Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ch4/ofi: Convert CUDA device id to handle for fi_mr_regattr #7156

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ch4/ofi: Convert CUDA device id to handle for fi_mr_regattr #7156

wants to merge 2 commits into from

Commits on Oct 9, 2024

  1. mpl/gpu: change MPL_gpu_device_handle_t to int 

    The abstraction of device id as an integer is a good abstraction above
MPL. The opaqueness of MPL_gpu_device_handle_t, on the other hand, makes
it useless, since the upperlayer can't do anything with it.

For ZE, simply expose the internal device id. For new GPU runtimes that
does support integer device ids, we can similarly do a map as in
mpl_gpu_ze.c.
    @hzhou @raffenet
    hzhou authored and raffenet committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c0a4b5d View commit details
    Browse the repository at this point in the history

  2. ch4/ofi: Convert CUDA device id to handle for fi_mr_regattr 

    Libfabric docs say that the value of the cuda field in the regattr
struct is the device handle gotten from cuDeviceGet, not the
ordinal. Fixes pmodels#7148.
    @raffenet
    raffenet committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e4cef78 View commit details
    Browse the repository at this point in the history