Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPIX_Continue: the basic implementation #7164

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JiakunYan
Copy link

@JiakunYan JiakunYan commented Oct 8, 2024

Pull Request Description

The basic implementation of the MPIX continuation proposal (mpiwg-hybrid/hybrid-issues#6).

A brief overview: it introduces a new way to attach a callback function (named continuation) to a request object corresponding to a pending operation and register it with a continuation request. The callback will be invoked once the corresponding operation is complete. The continuation request provides ways to manage the execution and completion of registered continuations.

What this PR is not covered.

  • Fortran binding.
  • Logic related to attaching callback to continuation requests.
  • Logic related to error propagation.

@JiakunYan JiakunYan force-pushed the continue-pr branch 2 times, most recently from ec921dc to 2371ea8 Compare October 17, 2024 21:31
@JiakunYan
Copy link
Author

test:mpich/ch4/ofi
test:mpich/ch4/ucx

@JiakunYan JiakunYan marked this pull request as ready for review October 17, 2024 21:35
@yfguo
Copy link
Contributor

yfguo commented Oct 17, 2024

test:mpich/ch4/ofi
test:mpich/ch4/ucx

@yfguo
Copy link
Contributor

yfguo commented Oct 21, 2024

test:mpich/ch4/ucx
test:mpich/ch4/ofi

@JiakunYan
Copy link
Author

@yfguo I found the following error message

ERROR: Workspace has a .git repository, but it appears to be corrupt.
hudson.plugins.git.GitException: Command "git rev-parse --resolve-git-dir /var/lib/jenkins/workspace/mpich-review-ch4-ucx/.git" returned status code 128:
stdout: 
stderr: fatal: not a gitdir '/var/lib/jenkins/workspace/mpich-review-ch4-ucx/.git'

Am I looking at the right error message that caused the tests to fail? Why can it have a corrupt .git repo?

@JiakunYan JiakunYan force-pushed the continue-pr branch 2 times, most recently from b558804 to d0fbe1a Compare November 18, 2024 20:11
@yfguo
Copy link
Contributor

yfguo commented Nov 19, 2024

test:mpich/ch4/ucx
test:mpich/ch4/ofi

@yfguo
Copy link
Contributor

yfguo commented Nov 20, 2024

test:mpich/ch4/ofi

@JiakunYan
Copy link
Author

@yfguo Could we try this again? I think I have fixed all errors.

@arakashic
Copy link
Contributor

test:mpich/ch4/ofi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants