Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch4/posix: fix made_progress in MPIDI_POSIX_progress_send #7174

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented Oct 15, 2024

Pull Request Description

Only update made_progress when sending the deferred operation is successful.

[skip warnings]

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou
Copy link
Contributor Author

hzhou commented Oct 15, 2024

test:mpich/ch4/most

@hzhou hzhou requested a review from raffenet October 15, 2024 22:15
Copy link
Contributor

@raffenet raffenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

Only update made_progress when sending the deferred operation is
successful.
@hzhou hzhou merged commit 5517088 into pmodels:main Oct 16, 2024
4 checks passed
@hzhou hzhou deleted the 2410_posix_prog branch October 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants