mpir_mem: simplify MPIR_CHKLMEM_ macros #7249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a memory class for local (temporary) allocations that should be freed after the operation -- typically before function exit.
Reduce the number of trivial parameters to make the MPIR_CHKLMEM macros easier to use and read. * Add MPIR_CHKLMEM_ADD so we also can track local buffers that are allocated in a subfunction. * Always use MPIR_CHKLMEM_MAX (default to 10) slots. It is a hassle to track how many local buffers we are tracking. * Remove the type-cast since it adds no value. * Local memory just use MPL_MEM_LOCAL as memory class. * Always use mpi_errno and goto fn_fail * Just use the "**nomem" message. Adding a variable name often does add more clarity for temporary local variables anyway.
|
test:mpich/ch3/most |
Reduce the number of trivial parameters to make the MPIR_CHKPMEM macros easier to use and read. * Similar to what we did with MPIR_CHKLMEM_MALLOC, but we retain the class param for MPIR_CHKPMEM_MALLOC. * Rename MPIR_CHKPMEM_REGISTER to MPIR_CHKPMEM_ADD. * Always use MPIR_CHKPMEM_MAX (default to 10) slots. * Remove the type-cast since it adds no value. * Always use mpi_errno and goto fn_fail * Just use the "**nomem" message. * Most usages of MPIR_CHKPMEM_COMMIT is unnecessary before exiting. It only has effect if there are additional error checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Reduce the number of trivial parameters to make the MPIR_CHKLMEM macros
easier to use and read.
MPIR_CHKLMEM_ADDso we also can track local buffers that areallocated in a subfunction.
MPIR_CHKLMEM_MAX(default to 10) slots. It is a hassle totrack how many local buffers we are tracking.
MPL_MEM_LOCALas memory class.more clarity for temporary local variables anyway.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.