Segfault with Compress::Raw::Zlib::Z_NULL

[atheurer]

This statement is part of a unit test for IO::Compress
Compress::Raw::Zlib versions 2.105 and older have no problems, anything newer than 2.105 results in segfault.

v2.105:

[root@dhcp31-192 Compress-Raw-Zlib-2.105]# make install
"/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Zlib.bs blib/arch/auto/Compress/Raw/Zlib/Zlib.bs 644
Manifying 1 pod document
Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
Installing /usr/local/lib64/perl5/5.34/auto/Compress/Raw/Zlib/Zlib.so
Installing /usr/local/lib64/perl5/5.34/Compress/Raw/Zlib.pm
Installing /usr/local/share/man/man3/Compress::Raw::Zlib.3pm
Appending installation info to /usr/lib64/perl5/perllocal.pod
[root@dhcp31-192 Compress-Raw-Zlib-2.105]# /usr/bin/perl -w -e '{ use Compress::Raw::Zlib ; eval "defined Compress::Raw::Zlib::Z_NULL" ; }'
[root@dhcp31-192 Compress-Raw-Zlib-2.105]#

v2.200 & v2.01:

[root@dhcp31-192 Compress-Raw-Zlib-2.200]# make install
"/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Zlib.bs blib/arch/auto/Compress/Raw/Zlib/Zlib.bs 644
Manifying 1 pod document
Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
Installing /usr/local/lib64/perl5/5.34/auto/Compress/Raw/Zlib/Zlib.so
Installing /usr/local/lib64/perl5/5.34/Compress/Raw/Zlib.pm
Installing /usr/local/share/man/man3/Compress::Raw::Zlib.3pm
Appending installation info to /usr/lib64/perl5/perllocal.pod
[root@dhcp31-192 Compress-Raw-Zlib-2.200]# /usr/bin/perl -w -e '{ use Compress::Raw::Zlib ; eval "defined Compress::Raw::Zlib::Z_NULL" ; }'
Segmentation fault (core dumped)

[atheurer]

[root@dhcp31-192 Compress-Raw-Zlib]# git bisect bad
8af98773d98efc398e8011e43b0a5bd148f93e93 is the first bad commit
commit 8af98773d98efc398e8011e43b0a5bd148f93e93
Author: pmqs <pmqs@cpan.org>
Date:   Sat Jun 18 16:35:04 2022 +0100

    zlib-ng changes

 .cirrus.yml                                  |  21 +-
 .github/workflows/linux-upstream-zlib-ng.yml |  78 +++++++
 Makefile.PL                                  |  78 ++++---
 Zlib.xs                                      | 319 ++++++++++++++++++---------
 config.in                                    |   1 +
 lib/Compress/Raw/Zlib.pm                     |  10 +-
 t/000prereq.t                                |  24 +-
 t/01version.t                                |  22 +-
 t/02zlib.t                                   |  15 +-
 t/07bufsize.t                                |  12 +-
 t/09limitoutput.t                            |   5 +-
 t/18lvalue.t                                 |  11 +-
 t/19nonpv.t                                  |   9 +-
 t/99pod.t                                    |   1 -
 t/compress/CompTestUtils.pm                  |  41 ++++
 15 files changed, 437 insertions(+), 210 deletions(-)
 create mode 100644 .github/workflows/linux-upstream-zlib-ng.yml

[atheurer]

Actual test failure (in IO::Compress):
https://github.com/pmqs/IO-Compress/blob/bc3e8dd1023425e27187624ff8f2b6539b28ee23/t/111const-deflate.t#L31

[atheurer]

This line

Compress-Raw-Zlib/Makefile.PL

Line 244 in 499ab23

push @names, { name => 'Z_NULL', type => 'PV' };

seems to trigger this problem.

[pmqs]

Thanks for the bug report @atheurer

Issue reproduced with

perl -MCompress::Raw::Zlib -e 'Compress::Raw::Zlib::Z_NULL'

Actual test failure (in IO::Compress): https://github.com/pmqs/IO-Compress/blob/bc3e8dd1023425e27187624ff8f2b6539b28ee23/t/111const-deflate.t#L31

Are you seeing this test fail? If so, can you share the output from running perl -V please along with th ename of the OS you are using please?

[pmqs]

@atheurer if you get a chance, could you try changing this line in Makefile.PL

    push @names, { name => 'Z_NULL', type => 'PV' };

to this

    push @names, { name => 'Z_NULL', type => 'UV' };

Does that still core for you? It fixes the issue for me.

[atheurer]

Yes, that fixes the issue for me, thanks.