Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add actions to alerts #2

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Ability to add actions to alerts #2

merged 3 commits into from
Nov 24, 2020

Conversation

mikecote
Copy link
Collaborator

No description provided.

group: 'threshold met',
params: {
documents: [{
fromAlertId: '{{alertId}}',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start!

I'd like to extend this later, to see if we can get some dates in here, which could require that we add mappings as well. We now have the date the action was scheduled in the variables via PR elastic/kibana#83195, and then probably the current date, and probably the difference between the two. We can then troll through this for another chart - "action execution lag" or such, probably with some kind of histogram or like one of the other scatterplots.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I'll work on that. I'm going to add executionTimeField: '@timestamp', to the connector so it will set the date the connector executed and with what you mention, I can fiddle through the date scheduled!

Copy link
Owner

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote marked this pull request as ready for review November 24, 2020 00:16
@mikecote mikecote merged commit a38382b into main Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants