Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eth): <- adds sha256 message signer to that #27

Merged
merged 4 commits into from
May 8, 2024

Conversation

gskapka
Copy link
Contributor

@gskapka gskapka commented May 7, 2024

...per title. As requested by @gitmp01.

@gskapka gskapka requested a review from ubordignon May 7, 2024 10:23
@gskapka gskapka self-assigned this May 7, 2024
@gitmp01
Copy link
Contributor

gitmp01 commented May 7, 2024

Great! thank you

@gskapka
Copy link
Contributor Author

gskapka commented May 7, 2024

Latest clippy has some lints to complain about elsewhere in the workspace, fixing those now.

@gskapka gskapka force-pushed the eth-sha256-signer branch from 722400d to 28ae143 Compare May 7, 2024 11:05
Copy link
Contributor

@ubordignon ubordignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gskapka gskapka merged commit 84b2bc0 into master May 8, 2024
5 checks passed
@gskapka gskapka deleted the eth-sha256-signer branch May 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants