Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket args in network config #28

Open
wants to merge 1 commit into
base: signed-event-encoding
Choose a base branch
from

Conversation

gitmp01
Copy link
Contributor

@gitmp01 gitmp01 commented May 14, 2024

No description provided.

@gitmp01 gitmp01 changed the base branch from master to sentinel-generic-event-signing May 14, 2024 16:37
@gitmp01 gitmp01 requested a review from ubordignon May 14, 2024 16:38
@gitmp01 gitmp01 force-pushed the fix/websocket-args-network-config branch from 04c53f9 to 2d35a44 Compare May 15, 2024 14:11
@gitmp01 gitmp01 changed the base branch from sentinel-generic-event-signing to signed-event-encoding May 15, 2024 14:12
Copy link
Contributor

@ubordignon ubordignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to getter access for SentinelConfig.

common/sentinel/src/config/config.rs Outdated Show resolved Hide resolved
@gitmp01 gitmp01 force-pushed the fix/websocket-args-network-config branch from 2d35a44 to 486ad63 Compare May 15, 2024 17:47
@gitmp01 gitmp01 force-pushed the fix/websocket-args-network-config branch from 486ad63 to 4d8762a Compare May 15, 2024 17:51
@gitmp01
Copy link
Contributor Author

gitmp01 commented May 15, 2024

Done!

@gitmp01 gitmp01 requested a review from ubordignon May 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants